ext/pcntl: use RETURN_THROWS() instead of RETURN_FALSE when exception…#21297
Closed
devnexen wants to merge 2 commits intophp:PHP-8.4from
Closed
ext/pcntl: use RETURN_THROWS() instead of RETURN_FALSE when exception…#21297devnexen wants to merge 2 commits intophp:PHP-8.4from
devnexen wants to merge 2 commits intophp:PHP-8.4from
Conversation
… is pending In pcntl_sigprocmask(), pcntl_sigwaitinfo(), and pcntl_sigtimedwait().
Member
|
This isn't really a fix. Returning false when throwing an exception is valid. I feel like the new code adds an extra check that makes the code harder to read. Adding a test is fine of course. |
Member
|
I agree with @ndossche, but the new test is good. |
…alid signals Revert the RETURN_THROWS() changes as RETURN_FALSE when an exception is pending is valid behaviour. Keep the test covering invalid signal handling for pcntl_sigprocmask(), pcntl_sigwaitinfo(), and pcntl_sigtimedwait().
Girgias
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is pending
In pcntl_sigprocmask(), pcntl_sigwaitinfo(), and pcntl_sigtimedwait().